Add support to configure multiple service ports#316
Merged
shivamerla merged 10 commits intoNVIDIA:mainfrom Mar 14, 2025
Merged
Conversation
Collaborator
shivamerla
commented
Feb 7, 2025
shivamerla
commented
- Default named port of "api" will be added with legacy .spec.port attribute
- Ability to setup multiple named ports "api", "metrics" etc.
- auto detection of metrics and api ports for probes and metrics collection
shivamerla
requested review from
ArangoGutierrez,
slu2011 and
visheshtanksale
as code owners
shivamerla
requested review from
shengnuo and
varunrsekar
and removed request for
ArangoGutierrez
a-mccarthy
reviewed
Feb 10, 2025
varunrsekar
requested changes
Feb 10, 2025
shengnuo
reviewed
Feb 12, 2025
varunrsekar
reviewed
Feb 12, 2025
shengnuo
reviewed
Feb 13, 2025
shivamerla
force-pushed
the
support_multiple_service_ports
branch
from
11f0e22 to
4d4944e
Compare
shivamerla
force-pushed
the
support_multiple_service_ports
branch
from
4d4944e to
41b8ae6
Compare
varunrsekar
requested changes
Mar 7, 2025
shivamerla
force-pushed
the
support_multiple_service_ports
branch
from
24913ab to
cca9071
Compare
shivamerla
force-pushed
the
support_multiple_service_ports
branch
4 times, most recently
from
0eea118 to
18e13fd
Compare
* Default named port of "api" will be added with legacy .spec.port attribute * Ability to setup multiple named ports "api", "metrics" etc. * auto detection of metrics and api ports for probes and metrics collection Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
shivamerla
force-pushed
the
support_multiple_service_ports
branch
from
18e13fd to
19ffd4a
Compare
varunrsekar
requested changes
Mar 14, 2025
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.